Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates several job scraper scripts to handle changes in the APIs and HTML structures of external job sites. The main focus is on adapting to new endpoints, updating data extraction logic, and improving robustness and accuracy of the job data collected.
API endpoint and data structure updates:
sites/arcadis.py,sites/vodafone.py) to use new API endpoints and adapt to changes in the JSON response structure, ensuring correct extraction of job count and positions. [1] [2]positionUrlfield, matching the new API format. [1] [2]HTML parsing and pagination improvements:
sites/danone.py) to use HTML parsing instead of JSON, iterating through paginated results and extracting job details from the updated page structure.Robustness improvements:
verify=Falseto allget_from_urlcalls in the Siemens Energy scraper (sites/siemensenergy.py) to handle SSL verification issues and prevent failures when fetching job data. [1] [2]These changes ensure that the scrapers continue to function correctly and collect accurate job information despite changes in the external job sites' APIs and HTML layouts.